gh-140715: Add %D format code support to strptime()#144819
Open
jyalim wants to merge 11 commits intopython:mainfrom
Open
gh-140715: Add %D format code support to strptime()#144819jyalim wants to merge 11 commits intopython:mainfrom
%D format code support to strptime()#144819jyalim wants to merge 11 commits intopython:mainfrom
Conversation
4 tasks
StanFromIreland
changed the title
%D token to strptime%D token to strptime()
StanFromIreland
changed the title
%D token to strptime()%D format code support to strptime()
Member
StanFromIreland
left a comment
StanFromIreland
left a comment
There was a problem hiding this comment.
You have to update test_strptime_exception_context to use a different (invalid) format code.
Also please add it here too:
Line 224 in 14cbd0e
…99+ definition for C99 %D; update additional tests
Contributor
Author
|
Thank you, those critical changes were made! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incrementally builds C99+ datetime support with addition of
%Dwith single line of code. Also adds tests and updates documentation.Continued effort from PR: #140647.
Documentation drops
(0)footnote, changes example date to increase readability for non-US readers.Passed all tests (especially changes to new one).
Passed patchcheck.
str*timeto C11 format codes #140715📚 Documentation preview 📚: https://cpython-previews--144819.org.readthedocs.build/